Adopt "future" behavior of statement() and frame()#2221
Merged
jacobtylerwalls merged 3 commits intopylint-dev:mainfrom Jun 22, 2023
Merged
Adopt "future" behavior of statement() and frame()#2221jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
statement() and frame()#2221jacobtylerwalls merged 3 commits intopylint-dev:mainfrom
Conversation
jacobtylerwalls
added
the
Maintenance
DanielNoord
reviewed
Jun 22, 2023
Collaborator
DanielNoord
left a comment
DanielNoord
left a comment
There was a problem hiding this comment.
One nit, rest looks good! Thanks for doing this!
| @@ -388,23 +388,9 @@ def statement(self, *, future: Literal[True]) -> NoReturn: | |||
| def statement(self, *, future: Literal[None, True] = None) -> Module | NoReturn: | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| def statement(self, *, future: Literal[None, True] = None) -> Module | NoReturn: | |
| def statement(self, *, future: Literal[None, True] = None) -> NoReturn: |
| self.assertTrue(node._proxied.parent) | ||
| self.assertEqual(node._proxied.root().name, value.__class__.__module__) | ||
| with self.assertRaises(AttributeError): | ||
| with self.assertRaises(StatementMissing): |
Collaborator
There was a problem hiding this comment.
Smart re-use of the test!
DanielNoord
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
As promised, adopt the "future" behavior of
statement()andframe().Refs #1217